Refactor: Delegate all handling to core #152
Conversation
|
I like this approach more than the previous attempts 👌 |
|
Remind me again why we needed POST instead of GET and why now GET is fine? |
I don't know why we needed POST, i thought there was a reason for it. I knew why the core was using Now it's fine since I found out that there were no specific reasons for the decision to use POST. |
Also sync tests to match output of core
simoneb
force-pushed
the
refactor/resync-with-core
branch
from
092e6ee
to
8a73e8c
Compare
|
@barelyhuman after updating the latest version of mercurius, which includes the change we needed, CI is failing. Not sure if you have a chance to look into this, but there must be something that was overlooked here. |
|
It seems to be reusing the existing mercurius instance, a teardown should help. I'll check it out in a bit |
Thanks 🙏 |
index.js
Outdated
| ) | ||
| context: contextFn, | ||
| routes: true, | ||
| additionalRouteProps: { |
There was a problem hiding this comment.
should be additionalRouteOptions, I don't have push access to the repo anymore
Changes
Test Modifications
methodand body type as supported by thecoreinstead of re-implementing their own detailsUpstream Dependency: mercurius-js/mercurius#1080
Closes #4